Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(upstream): upgrade esbuild@0.11.19 #3282

Merged
merged 1 commit into from
May 6, 2021
Merged

fix(upstream): upgrade esbuild@0.11.19 #3282

merged 1 commit into from
May 6, 2021

Conversation

nihalgonsalves
Copy link
Member

@nihalgonsalves nihalgonsalves commented May 6, 2021 •
edited
Loading

Description

I tried the latest master against a project, and it didn't work. esbuild 0.11.19 fixes a code splitting issue I reported: evanw/esbuild#1252, which is probably relevant for many Vite users. (e.g. @apollo/client users, react-redux users, and perhaps other combinations of dependencies), so we should get this out before we release v2.3.0.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@nihalgonsalves nihalgonsalves requested a review from patak-dev May 6, 2021 08:11
@nihalgonsalves nihalgonsalves changed the title chore: upgrade esbuild@0.11.19 fix(upstream): upgrade esbuild@0.11.19 May 6, 2021
@nihalgonsalves nihalgonsalves added bug: upstream Bug in a dependency of Vite p3-minor-bug An edge case that only affects very specific usage (priority) labels May 6, 2021
@patak-dev patak-dev merged commit b0dd69d into vitejs:main May 6, 2021
@nihalgonsalves nihalgonsalves deleted the ng/esbuild0.11.19 branch May 6, 2021 08:30
This was referenced May 11, 2021
Closed
Closed
Closed
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
@nihalgonsalves @fi3ework
fix: upgrade to esbuild@0.11.19 (vitejs#3282)
1f4c5ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
bug: upstream Bug in a dependency of Vite p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nihalgonsalves @patak-dev @Shinigami92