Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): remove process listeners on server close, fix #2616 #2619

Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix(dev): remove process listeners on server close, fix #2616 #2619

merged 1 commit into from
Mar 23, 2021

Conversation

patak-dev
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Description

See #2616
Signal event handlers are not removed during server.close(), causing a memory leak

This happens because the server is restarted (closed and recreated) any time there is a change in the config file.

Additional context

This PR also removes the listener from process.stdin 'end', which could also cause a memory leak but was not reported in the original issue.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 20, 2021
@patak-dev
Copy link
Member Author

@shigma it would be great if you could review that this PR works as you expect for your use case. Thanks!

@patak-dev patak-dev requested a review from antfu March 21, 2021 08:06
@shigma
Copy link
Contributor

shigma commented Mar 21, 2021

@matias-capeletto Thanks for your quick response! It looks good to me.

@patak-dev patak-dev merged commit 74b360b into vitejs:main Mar 23, 2021
@nihalgonsalves nihalgonsalves mentioned this pull request May 11, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patak-dev @shigma @underfin