fix: always transform applicable requests #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in https://github.com/Rich-Harris/vite-repro-transformation, Vite only transforms files when they are imported, and not requested any other way, because
transformMiddlewarehas the following check:This line was removed in #1496 so that it's possible to view transformed files in a new tab, but that change was reverted in 64fde38 due to #1507. I'm not sure what's happening in #1507 but it feels like the
acceptcheck might be masking the real issue?The current behaviour does cause problems — as alluded to in #1496, it makes debugging harder, but it also means that you can't (for the example that motivated this PR) inject a
<link>in SSR'd content that contains a stylesheet that was imported by a module loaded withssrLoadModule.More broadly, I'd argue it makes things less predictable. Unless there's a rationale for the current behaviour that I'm missing?