refactor: top-level createEnvironment is client-only #18475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@bluwy proposed to remove the top level
createEnvironment
as it didn't make sense as a default. The types would get more complex though, and after #18465, we can instead make the top-levelcreateEnvironment
be client-only instead. This is also interesting because now a single environment could potentially be configured as:Maybe we should recommend the form below, but I think the above is interesting to consider too (it isn't the reason for this PR though).