-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom Angular variants #18410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a single variant is a bit strange at first, but I think it is a good idea to keep the option even if there is a single choice. We would be sending the wrong message if we directly forward to Analog. It would be great if we could add an Angular option soon though.
I'll add it now I added the standard Angular CLI command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! ❤️
Nice! Recommendation would be to change |
I'll do it right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝
name: 'custom-angular', | ||
display: 'Angular ↗', | ||
color: red, | ||
customCommand: 'npx -p @angular/cli@latest ng new TARGET_DIR', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gioboa Could this be npm exec @angular/cli@latest new TARGET_DIR
instead? create-vite
has special handling to execute the CLI with yarn/pnpm/bun dynamically if npm exec
here is used, depending on the package manager that invoked create-vite
in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's working.
I created the PR #18425
Thanks
Based on the feedback of #18330 I created this Angular variant
Angular CLI & Analog.js