Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom Angular variants #18410

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat: add custom Angular variants #18410

merged 3 commits into from
Oct 21, 2024

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Oct 21, 2024

Based on the feedback of #18330 I created this Angular variant

Angular CLI & Analog.js

image

image

@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 21, 2024
patak-dev
patak-dev previously approved these changes Oct 21, 2024
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a single variant is a bit strange at first, but I think it is a good idea to keep the option even if there is a single choice. We would be sending the wrong message if we directly forward to Analog. It would be great if we could add an Angular option soon though.

@gioboa
Copy link
Contributor Author

gioboa commented Oct 21, 2024

Having a single variant is a bit strange at first, but I think it is a good idea to keep the option even if there is a single choice. We would be sending the wrong message if we directly forward to Analog. It would be great if we could add an Angular option soon though.

I'll add it now


I added the standard Angular CLI command

@gioboa gioboa changed the title feat: add custom Analog.js variant feat: add custom Angular variants Oct 21, 2024
@gioboa gioboa requested a review from patak-dev October 21, 2024 10:35
patak-dev
patak-dev previously approved these changes Oct 21, 2024
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! ❤️

@brandonroberts
Copy link

Nice! Recommendation would be to change Analog.js to just Analog.

@gioboa
Copy link
Contributor Author

gioboa commented Oct 21, 2024

Nice! Recommendation would be to change Analog.js to just Analog.

I'll do it right now.
Thanks

Copy link

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@gioboa gioboa requested a review from patak-dev October 21, 2024 13:15
@patak-dev patak-dev merged commit ac1fd41 into vitejs:main Oct 21, 2024
14 checks passed
name: 'custom-angular',
display: 'Angular ↗',
color: red,
customCommand: 'npx -p @angular/cli@latest ng new TARGET_DIR',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gioboa Could this be npm exec @angular/cli@latest new TARGET_DIR instead? create-vite has special handling to execute the CLI with yarn/pnpm/bun dynamically if npm exec here is used, depending on the package manager that invoked create-vite in the first place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's working.
I created the PR #18425
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants