Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename runner.destroy() to runner.close() #18304

Merged
merged 1 commit into from
Oct 9, 2024
Merged

refactor: rename runner.destroy() to runner.close() #18304

merged 1 commit into from
Oct 9, 2024

Conversation

patak-dev
Copy link
Member

Description

Rename to be consistent with server.close() and other APIs.

@stackblitz StackBlitz
Copy link

stackblitz bot commented Oct 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

hi-ogawa
hi-ogawa approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

sapphi-red
sapphi-red approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@sapphi-red sapphi-red added enhancement New feature or request feat: environment API Vite Environment API and removed enhancement New feature or request labels Oct 9, 2024
@sapphi-red sapphi-red merged commit cd368f9 into main Oct 9, 2024
11 of 12 checks passed
@sapphi-red sapphi-red deleted the refactor/runner-destroy-renamed-closed branch October 9, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees
No one assigned
Labels
feat: environment API Vite Environment API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patak-dev @hi-ogawa @sapphi-red