Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace parse with splitFileAndPostfix #18185

Merged
merged 5 commits into from
Sep 25, 2024
Merged

refactor: replace parse with splitFileAndPostfix #18185

merged 5 commits into from
Sep 25, 2024
+15 −11

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 24, 2024

@stackblitz StackBlitz
Copy link

stackblitz bot commented Sep 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

hi-ogawa
hi-ogawa previously approved these changes Sep 25, 2024
View reviewed changes
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Sep 25, 2024
@btea btea changed the title refactor: replace parse with URL refactor: replace parse with splitFileAndPostfix Sep 25, 2024
sapphi-red
sapphi-red approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 6f030ec into vitejs:main Sep 25, 2024
13 checks passed
@btea btea deleted the refactor/replace-parse-with-URL branch September 26, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

@hi-ogawa hi-ogawa hi-ogawa left review comments

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@btea @patak-dev @hi-ogawa @sapphi-red