Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary escape #18044

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 6, 2024

Description

Remove unnecessary character escape.

Copy link

stackblitz bot commented Sep 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea btea added the p1-chore Doesn't change code behavior (priority) label Sep 8, 2024
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are covered by no-useless-escape.
It was disabled here and I think we should remove it:

'no-useless-escape': 'off',

@btea
Copy link
Collaborator Author

btea commented Sep 9, 2024

Thanks for your review, I have updated it.

Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 8062d36 into vitejs:main Sep 9, 2024
12 checks passed
@btea btea deleted the refactor/remove-unnecessary-escape branch September 9, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants