Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert only watch .env files in envDir (#12587) #13217

Merged
merged 1 commit into from
May 16, 2023

Conversation

patak-dev
Copy link
Member

This reverts #12587, commit 26d8e72.

Description

@bartlomieju reported Windows crashes and he tracked the issue down to this PR.

disableGlobbing: true is used above, so we can't use globbing. @sapphi-red was disableGlobbing needed when implementing #8939, or it was an optimization because globbing was used anymore? @sun0day I think we could revert and then review how to reapply the optimization (if it is worth doing so).


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented May 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 16, 2023
@sapphi-red
Copy link
Member

disableGlobbing: true was there before #8939, it seems it's added by #2211 to fix #2179.

@patak-dev
Copy link
Member Author

Ah, I see. Ok, let's merge the revert for now

@patak-dev patak-dev merged commit 0fd4616 into main May 16, 2023
@patak-dev patak-dev deleted the revert/12587-globbing-for-env-files branch May 16, 2023 13:51
@sun0day
Copy link
Member

sun0day commented May 16, 2023

Is there an original issue to track this bug?

@patak-dev
Copy link
Member Author

@sun0day not in Vite core at least. @bartlomieju, do you have a link to some of the reports you got in Deno?

@bartlomieju
Copy link
Contributor

Thanks for a quick fix, here's the issue with user reports: denoland/deno#19067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants