fix: dev server resolve plugin for win32 #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is the right fix. The double slash was intentional. Will need a proper repro for windows. |
|
FWIW, in my win machine, |
|
Oh I think I know now, this is in VitePress where it directly feeds a non-normalized fs path after I think we should handle that in Vite core though. So the proper fix here should be something that can handle all the following cases:
|
|
Got it. I moved this logic to a helper in utils so it could be tested independently later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a slash check in
plugins/resolve.tsresolved()that was causing the dev server to fail for paths in windows.