Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unwrapId and pass ssr flag when adding to moduleGraph in this.load #13083

Merged

Conversation

patak-dev
Copy link
Member

Description

Found while checking #13030. It may be a possible cause of the issue if Playwright started using the this.load function with virtual modules in dev mode.

We should do the same as we are doing here:


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@stackblitz
Copy link

stackblitz bot commented May 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member Author

@gajus, a shot in the dark, but you could try if you have some time. I think the issue may be elsewhere though.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 3, 2023
@patak-dev patak-dev merged commit 9041e19 into main May 4, 2023
@patak-dev patak-dev deleted the fix/unwrap-id-before-adding-to-module-graph-in-this-load branch May 4, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants