Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused exports data props #12740

Merged
merged 1 commit into from
Apr 4, 2023
Merged

refactor: remove unused exports data props #12740

merged 1 commit into from
Apr 4, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 4, 2023

Description

Some props of ExportsData are not used anymore with the current logic of needsInterop

I'd like to remove extractExportsData some day to simplify things, but it's still needed for:

  1. Process .js as .jsx in dependencies
  2. Needs interop check 😢

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Apr 4, 2023
@stackblitz
Copy link

stackblitz bot commented Apr 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy commented Apr 4, 2023
View reviewed changes
packages/vite/src/node/optimizer/index.ts
Comment on lines -1177 to -1182
// Ensure that optimization won't fail by defaulting '.js' to the JSX parser.
// This is useful for packages such as Gatsby.
esbuildOptions.loader = {
'.js': 'jsx',
...esbuildOptions.loader,
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's intentional, but this code mutates the global esbuildOptions config when using this function and hitting this code path. I've removed it as it should already be handled at

vite/packages/vite/src/node/optimizer/index.ts

Lines 729 to 736 in 0948803

if (exportsData.jsxLoader && !esbuildOptions.loader?.['.js']) {
// Ensure that optimization won't fail by defaulting '.js' to the JSX parser.
// This is useful for packages such as Gatsby.
esbuildOptions.loader = {
'.js': 'jsx',
...esbuildOptions.loader,
}
}

@patak-dev
Copy link
Member

Nice one! Looking forward to a far future where we can delete the needs interop check 🥲

@patak-dev patak-dev merged commit 4538bfe into main Apr 4, 2023
@patak-dev patak-dev deleted the refactor-exports-data branch April 4, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @patak-dev