build: reduce package size (#18517)

vitejs · Oct 30, 2024 · b83f60b · b83f60b
1 parent 192d555
commit b83f60b
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 86 deletions.
diff --git a/package.json b/package.json
@@ -103,8 +103,7 @@
     },
     "patchedDependencies": {
       "http-proxy@1.18.1": "patches/http-proxy@1.18.1.patch",
-      "sirv@3.0.0": "patches/sirv@3.0.0.patch",
-      "acorn@8.14.0": "patches/acorn@8.14.0.patch"
+      "sirv@3.0.0": "patches/sirv@3.0.0.patch"
     },
     "peerDependencyRules": {
       "allowedVersions": {

diff --git a/packages/vite/LICENSE.md b/packages/vite/LICENSE.md
@@ -448,33 +448,6 @@ Repository: git+https://github.com/sapphi-red/artichokie.git
 
 ---------------------------------------
 
-## astring
-License: MIT
-By: David Bonnet
-Repository: https://github.com/davidbonnet/astring.git
-
-> Copyright (c) 2015, David Bonnet <david@bonnet.cc>
-> 
-> Permission is hereby granted, free of charge, to any person obtaining a copy
-> of this software and associated documentation files (the "Software"), to deal
-> in the Software without restriction, including without limitation the rights
-> to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-> copies of the Software, and to permit persons to whom the Software is
-> furnished to do so, subject to the following conditions:
-> 
-> The above copyright notice and this permission notice shall be included in
-> all copies or substantial portions of the Software.
-> 
-> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-> IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-> FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-> AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-> LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-> OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-> THE SOFTWARE.
-
----------------------------------------
-
 ## braces, fill-range, is-number, micromatch
 License: MIT
 By: Jon Schlinkert, Brian Woodward, Elan Shanker, Eugene Sharygin, hemanth.hm
@@ -1490,10 +1463,10 @@ Repository: vercel/ms
 
 ---------------------------------------
 
-## object-assign, pify
+## object-assign
 License: MIT
 By: Sindre Sorhus
-Repositories: sindresorhus/object-assign, sindresorhus/pify
+Repository: sindresorhus/object-assign
 
 > The MIT License (MIT)
 > 
@@ -1906,34 +1879,6 @@ Repository: https://github.com/TrySound/postcss-value-parser.git
 
 ---------------------------------------
 
-## read-cache
-License: MIT
-By: Bogdan Chadkin
-Repository: git+https://github.com/TrySound/read-cache.git
-
-> The MIT License (MIT)
-> 
-> Copyright 2016 Bogdan Chadkin <trysound@yandex.ru>
-> 
-> Permission is hereby granted, free of charge, to any person obtaining a copy of
-> this software and associated documentation files (the "Software"), to deal in
-> the Software without restriction, including without limitation the rights to
-> use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
-> the Software, and to permit persons to whom the Software is furnished to do so,
-> subject to the following conditions:
-> 
-> The above copyright notice and this permission notice shall be included in all
-> copies or substantial portions of the Software.
-> 
-> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-> IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
-> FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
-> COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
-> IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
-> CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
----------------------------------------
-
 ## readdirp
 License: MIT
 By: Thorsten Lorenz, Paul Miller

diff --git a/packages/vite/rollup.config.ts b/packages/vite/rollup.config.ts
@@ -43,7 +43,17 @@ const clientConfig = defineConfig({
 
 const sharedNodeOptions = defineConfig({
   treeshake: {
-    moduleSideEffects: 'no-external',
+    moduleSideEffects(id, external) {
+      // These nested dependencies should be considered side-effect free
+      // as it's not set within their package.json
+      if (
+        id.includes('node_modules/astring') ||
+        id.includes('node_modules/acorn')
+      ) {
+        return false
+      }
+      return !external
+    },
     propertyReadSideEffects: false,
     tryCatchDeoptimization: false,
   },
@@ -133,13 +143,18 @@ const nodeConfig = defineConfig({
         },
       ],
       // postcss-import uses the `resolve` dep if the `resolve` option is not passed.
-      // However, we always pass the `resolve` option. Remove this import to avoid
-      // bundling the `resolve` dep.
+      // However, we always pass the `resolve` option. It also uses `read-cache` if
+      // the `load` option is not passed, but we also always pass the `load` option.
+      // Remove these two imports to avoid bundling them.
       'postcss-import/index.js': [
         {
           src: 'const resolveId = require("./lib/resolve-id")',
           replacement: 'const resolveId = (id) => id',
         },
+        {
+          src: 'const loadContent = require("./lib/load-content")',
+          replacement: 'const loadContent = () => ""',
+        },
       ],
       'postcss-import/lib/parse-styles.js': [
         {

diff --git a/patches/acorn@8.14.0.patch b/patches/acorn@8.14.0.patch
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml