fix: fix types errors (#2726)

vitejs · Mar 27, 2021 · 9716582 · 9716582
1 parent fa30f76
commit 9716582
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/vite/src/node/plugins/importAnalysis.ts b/packages/vite/src/node/plugins/importAnalysis.ts
@@ -107,7 +107,7 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
 
       const rewriteStart = Date.now()
       await init
-      let imports: ImportSpecifier[] = []
+      let imports: readonly ImportSpecifier[] = []
       try {
         imports = parseImports(source)[0]
       } catch (e) {
@@ -310,10 +310,8 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
         const isDynamicImport = dynamicIndex >= 0
 
         // static import or valid string in dynamic import
-        const isLiteralId = !!specifier
-
         // If resolvable, let's resolve it
-        if (isLiteralId) {
+        if (!!specifier) {
           // skip external / data uri
           if (isExternalUrl(specifier) || isDataUrl(specifier)) {
             continue

diff --git a/packages/vite/src/node/plugins/importAnalysisBuild.ts b/packages/vite/src/node/plugins/importAnalysisBuild.ts
@@ -102,7 +102,7 @@ export function buildImportAnalysisPlugin(config: ResolvedConfig): Plugin {
 
       await init
 
-      let imports: ImportSpecifier[] = []
+      let imports: readonly ImportSpecifier[] = []
       try {
         imports = parseImports(source)[0]
       } catch (e) {