fix(_updateItemsInRange) large items should not disappear #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this and commented here #1573 (comment) |
yotamberk
approved these changes
Jun 19, 2023
|
Hi @yotamberk apologies if this is not the place to ask, but this PR fixes a big problem in my app. Is it possible for you or someone else to publish a new release with this fix? |
|
@blueberryMonkeySquid , unfortunately, this PR didn't fix the bug completely. |
|
@alexdeia thank you for the response, I see the behavior you captured in the video. Looks like it's related to vertical scrolling? The large items in my timeline disappear when I scroll horizontally. I got rid of vertical scrolling due to another bug so maybe that's why I haven't seen anything disappear after testing with this change. |
|
🎉 This PR is included in version 7.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(_updateItemsInRange) large items should not disappear
This is to address #1573
Adds a condition to only hide items when the group is not visible and height is defined.
The problem seems to be happening when a group is redrawn and height is temporarily
undefined.Group._updateItemsInRangeis called before the group height gets defined inredraw. When height is undefined in_updateItemsInRange, it considers the group invisible and hides the items (lines 908-914 Group.js). Then for the next paint, when height is defined, the group is now visible but there are no items.