fix small bug in run.sh + drop support for php < 7.2 + update CHANGELOG #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsifford
commented
Dec 7, 2019
| @@ -21,7 +19,7 @@ for php_version in "${php_versions[@]}"; do | |||
| -t "visiblevc/wordpress:latest" \ | |||
| -t "visiblevc/wordpress:latest-php${php_version}" \ | |||
| -t "visiblevc/wordpress:$npm_package_version-php${php_version}" \ | |||
| "$dockerfile_dir" | |||
| . | |||
There was a problem hiding this comment.
Not needed since running using npm will ensure that the $PWD is the root of the repo.
|
Okay, so this got a bit more complicated... It appears the configuration for php7.4 extensions has diverged from versions below it, so we're no longer able to share dockerfiles anymore. See here for an example of this. There are other such cases as well. So have a look at this and let me know what you think @karellm |
karellm
approved these changes
Dec 9, 2019
|
Sorry for the delay. Sounds good. We've been using this at my workplace so I'm able to find and correct issues relatively quickly. I'll be sure to do so if we notice any probs with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in run.sh resulting from a typo in a
findflag.Additionally, this PR drops support for PHP < 7.2 to align with php
Finally, the build script was updated to remove useless cruft and the CHANGELOG was brought up to date.