Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing site health extensions #154

Merged
merged 1 commit into from
May 12, 2019
Merged

Conversation

dsifford
Copy link
Collaborator

WordPress 5.2 now comes with a "Site Health" feature. Currently, this feature prints out a warning due to the fact that the image didn't have bcmath or imagick PHP extensions installed.

This PR installs and enables those extensions, which fixes those warnings.

Let me know if you have any questions.

Ping: @karellm

Copy link
Collaborator

@karellm karellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I just added a question.

@@ -53,8 +61,7 @@ RUN echo "deb http://ftp.debian.org/debian $(sed -n 's/^VERSION=.*(\(.*\)).*/\1/
-o /usr/local/bin/wp https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar \
-o /etc/bash_completion.d/wp-cli https://raw.githubusercontent.com/wp-cli/wp-cli/master/utils/wp-completion.bash \
&& a2enconf fqdn \
&& a2enmod rewrite expires \
&& service apache2 restart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it needed anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't ever needed in the first place. We start apache at the end of run.sh.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense. LGTM!

@dsifford dsifford merged commit 2618d60 into master May 12, 2019
@dsifford dsifford deleted the dsifford-fix-missing-extensions branch May 12, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants