Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis support #139

Merged
merged 1 commit into from
May 25, 2018
Merged

add redis support #139

merged 1 commit into from
May 25, 2018

Conversation

dsifford
Copy link
Collaborator

@dsifford dsifford commented May 25, 2018

This PR simply adds support for Redis object caching. Nothing particularly interesting or fancy.

cc: @karellm

Edit: The reason for the tweaks to the zip configuration is because there was a warning message that showed up during build unrelated to the redis changes that stated libzip was being removed as a dependency of PHP soon and needed to be installed manually.

@dsifford dsifford requested a review from karellm May 25, 2018 15:19
Copy link
Collaborator

@karellm karellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only comment might be to a note on the release about the UTF8 change

@dsifford
Copy link
Collaborator Author

dsifford commented May 25, 2018

@karellm Re: adding note about charset support in changelog -- will do!

Edit: Er, wait.. It's already there. Are you talking about something else?

@karellm
Copy link
Collaborator

karellm commented May 25, 2018

My bad, I didn't read it carefully. All good!

@dsifford dsifford merged commit 017a8d5 into master May 25, 2018
@dsifford dsifford deleted the dsifford-redis branch May 25, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants