Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more colors in dropdown section #1

Closed
58 of 72 tasks
vishal-codes opened this issue Sep 30, 2021 · 42 comments · Fixed by #56, #109, #116 or #135
Closed
58 of 72 tasks

Add more colors in dropdown section #1

vishal-codes opened this issue Sep 30, 2021 · 42 comments · Fixed by #56, #109, #116 or #135
Labels
good first issue Good for newcomers Hacktoberfest

Comments

@vishal-codes
Copy link
Owner

vishal-codes commented Sep 30, 2021 •
edited
Loading

As of now the Dropdown section of the project only supports two colors (Blue and Yellow). We can add more colours.
Before making changes please make sure that you have completed steps till Branching.

Steps for adding more colours

  1. change the directory from present to the src/data/colorOptions.js file.
  2. now edit the array named colorOptions by adding a new item and assign the label and value with the colour name (please follow the casing)
  3. save the changes and commit

Note: Add the colour's in alphabetical order and if u want to get you
PR eligible for Hacktoberfest then u gotta at least add 2 colours and 2 languages in a single PR

List of colour's to be added (NOTE: You don't need to add all the colours, just add one or two colour's. Not more than two.)

  • AntiqueWhite
  • Aqua
  • Aquamarine
  • Blue
  • BlueViolet
  • Brown
  • CadetBlue
  • Chartreuse
  • Chocolate
  • Coral
  • CornflowerBlue
  • Crimson
  • Cyan
  • DarkBlue
  • DarkCyan
  • DarkGoldenRed
  • DarkGray
  • DarkGreen
  • DarkKhaki
  • DarkMagenta
  • DarkOliveGreen
  • DarkOrange
  • DarkOrchid
  • DarkRed
  • DarkTurquoise
  • DarkViolet
  • DeepPink
  • DeepSkyBlue
  • DimGray
  • DodgerBlue
  • ForestGreen
  • Fuchsia
  • Gold
  • Green
  • GreenYellow
  • HotPink
  • IndianRed
  • Indigo
  • Khaki
  • Lavender
  • LightBlue
  • LightCoral
  • LightGreen
  • LightPink
  • LightSalmon
  • LightSeaGreen
  • Lime
  • Linen
  • Magenta
  • Maroon
  • MediumBlue
  • MidnightBlue
  • NavajoWhite
  • Olive
  • OrangeRed
  • Orchid
  • PaleGreen
  • PaleVioletRed
  • Peru
  • Pink
  • Plum
  • Purple
  • Red
  • SandyBrown
  • Silver
  • Snow
  • Tomato
  • Turquoise
  • Violet
  • WhiteSmoke
  • Yellow
  • YellowGreen
@vishal-codes vishal-codes added the good first issue Good for newcomers label Sep 30, 2021
This was referenced Sep 30, 2021
Merged
Merged
@Ayushi7456
Copy link
Contributor

Ayushi7456 commented Oct 1, 2021 •
edited
Loading

I would like to work on this if it's a part of Hacktoberfest.

@vishal-codes
Copy link
Owner Author

I would like to work on this if it's a part of Hacktoberfest.

Yes @Ayushi7456 please go ahead! 👍

@Vidushi-Gupta
Copy link
Contributor

Vidushi-Gupta commented Oct 1, 2021 •
edited
Loading

Hi, could you please assign me this for hacktoberfest? Also, could you add the hacktober label for it to qualify for hacktoberfest? Thank you

@vishal-codes
Copy link
Owner Author

Hi, could you please assign me this for hacktoberfest?

Yes @Vidushi-Gupta please go ahead 👍 . Add any one color👍

@Amiyanshu-web
Copy link
Contributor

Can I add a color

@ssm0801
Copy link
Contributor

ssm0801 commented Oct 1, 2021

Can I work on this ?

@Vidushi-Gupta
Copy link
Contributor

Hi, could you please assign me this for hacktoberfest?

Yes @Vidushi-Gupta please go ahead 👍 . Add any one color👍

Just added a PR. Thank you!

@ayushhagarwal
Copy link

raised a PR for Linen

@OmDharme
Copy link

OmDharme commented Oct 1, 2021

Can I work on this?

vishal-codes pushed a commit that referenced this issue Oct 1, 2021
@Vidushi-Gupta
Merge pull request #1 from Vidushi-Gupta/Vidushi-Gupta
e5f0837 
Added 'Maroon' color in the dropdown section
vishal-codes pushed a commit that referenced this issue Oct 1, 2021
@Sejal-16
Merge pull request #1 from Sejal-16/Sejal-16-Add-Aqua-Color
1f1a44d 
Add Aqua Color
@Sejal-16
Copy link
Contributor

Sejal-16 commented Oct 1, 2021

will this pull request count towards hacktober fest

@2201monesh
Copy link

2201monesh commented Oct 1, 2021 •
edited
Loading

Hey @vishal-codes I have raised a PR #30 can you give it a hacktoberfest label

@vishal-codes
Copy link
Owner Author

vishal-codes commented Oct 1, 2021 •
edited
Loading

will this pull request count towards hacktober fest

No, at that time I wasn't able to add the labels, Now the labels are available if u make a new pr with new changes then I can give ur pr a label 🚀

@vishal-codes
Copy link
Owner Author

Hey @vishal-codes I have raised a PR #30 can you give it a hacktoberfest label

yaa sure

@hellodeborahuk
Copy link
Contributor

Can I do one colour please?

@sakshamgurbhele
Copy link
Collaborator

Can I do one colour please?

Go ahead

@ayangupta9
Copy link
Contributor

Hi! May I add a color too?

@KavyaJaiswal KavyaJaiswal mentioned this issue Oct 1, 2021
Merged
@sakshamgurbhele
Copy link
Collaborator

Hi! May I add a color too?

Sure, Go ahead @ayangupta9

@Sparsh-Malhotra Sparsh-Malhotra mentioned this issue Oct 1, 2021
Merged
@Sparsh-Malhotra
Copy link
Contributor

Hi @vishal-codes Please merge the PR. Thank You

@ghost
Copy link

ghost commented Oct 1, 2021

Hi @vishal-codes I have added DarkOrange and DarkOliveGreen color please merge my PR #58 . Thank you

@alceil
Copy link

alceil commented Oct 1, 2021

Can i work on this issue?

@alceil alceil mentioned this issue Oct 1, 2021
Closed
@Abhiram970
Copy link

Abhiram970 commented Oct 1, 2021 •
edited
Loading

Added IndianRed and LightBlue colours :D please merge my PR #64

@vishal-codes vishal-codes reopened this Oct 2, 2021
@sauloviniciusf
Copy link
Contributor

adding Blue Violet color #77

@vishal-codes

I closed this one, cause a refactor was made with how colors options are defined, and on this refactor the color I originally addeed was added too. So, I added another one :) CornflowerBlue.

#102

@vishal-codes vishal-codes reopened this Oct 3, 2021
@ghost ghost mentioned this issue Oct 3, 2021
Merged
@jatnnik jatnnik mentioned this issue Oct 3, 2021
Merged
@prashant-garg-815
Copy link
Contributor

I would like to contribute to this issue

@aldy-san aldy-san mentioned this issue Oct 3, 2021
Merged
@vishal-codes vishal-codes reopened this Oct 3, 2021
@mohammedafeef
Copy link

4 colors are added #119

@sadathshariff
Copy link
Contributor

Hi @vishal-codes I have added 2 Colors and 2 languages #118 Please Look into it

@arthur322 arthur322 mentioned this issue Oct 4, 2021
Merged
@sakshamgurbhele
Copy link
Collaborator

Lovely people, it will be a little easy for Maintainers if you do not link this issue! It is getting close whenever we are merging a PR.

ヽ(^o^)丿
Happy Open-Source.

@thunderfreak
Copy link
Contributor

hey, one of my prs have already been merged (which added 2 languages). Can I still contribute on this issue?

@developer-nobita developer-nobita mentioned this issue Oct 4, 2021
Closed
@sakshamgurbhele
Copy link
Collaborator

hey, one of my prs have already been merged (which added 2 languages). Can I still contribute on this issue?

Yeah, why not

@enriquetolentinog enriquetolentinog mentioned this issue Oct 4, 2021
Merged
@sadathshariff
Copy link
Contributor

Hi, @vishal-codes i would like to add MediumBlue
MidnightBlue can you please assign this to me

@sakshamgurbhele
Copy link
Collaborator

Hi, @vishal-codes i would like to add MediumBlue MidnightBlue can you please assign this to me

Hey @sadathshariff, you can open a PR. no worries

This was referenced Oct 5, 2021
Closed
Merged
@SanskritiKhatiyan
Copy link
Contributor

SanskritiKhatiyan commented Oct 7, 2021 •
edited
Loading

@vishal-codes Hey!! I have added two colors plzz merge the PR. #148

@vishal-codes vishal-codes reopened this Oct 7, 2021
@sakshamgurbhele sakshamgurbhele mentioned this issue Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone