Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website: Port Plot example to UBO #9307

Merged
merged 3 commits into from
Dec 22, 2024
Merged

website: Port Plot example to UBO #9307

merged 3 commits into from
Dec 22, 2024

Conversation

felixpalmer
Copy link
Collaborator

For #9056

Change List

  • Port AxesLayer & SurfaceLayer to UBO
  • Remove modelsByName & tidy

@felixpalmer felixpalmer mentioned this pull request Dec 18, 2024
Open
36 tasks
@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Coverage Status

coverage: 91.701%. remained the same
when pulling f3dbc54 on felix/plot-layers-ubo
into f36b2ff on master.

ibgreen
ibgreen approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lean, mean, UBO porting machine, that is!

@felixpalmer felixpalmer merged commit 7c081f9 into master Dec 22, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/plot-layers-ubo branch December 22, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

@donmccurdy donmccurdy Awaiting requested review from donmccurdy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @ibgreen