carto: Fix caching in ClusterTileLayer #9167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigg
force-pushed
the
zbigg/carto-cluster-tile-layer-caching-fix
branch
from
3d37d50 to
33a1f87
Compare
zbigg
changed the title
felixpalmer
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ClusterTileLayer was relying on
Tileinstances to be new or cleared or reset when new tile is loaded and usedtile.userDataas cache. It appears, that reloading tile doesn't instantiate new tile ... or retainsuserDataand thus new tile would reuse aggregations from old version of self.Fix creates separate cache in layer state to keep aggregations keyed by tile content.
Change List