Publish NPM packages from CI #8828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/publish-from-ci
branch
from
4077d2f to
cbfb2e1
Compare
Does this affect the publish workflow you described above? If a non-admin is trying to publish a new release on a visgl repository, do we also support a workflow allowing non-admins to cut the release? Example:
The only minor issue I see in that workflow is that Git tags are pushed before the PR is approved and merged, but that isn't necessarily a problem. |
|
My plan is to just manage publish rights by managing push permission to the release branches. If someone is allowed to publish then they will be allowed to push. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
After this PR, the publish workflow will be
masterfor alpha/beta in development or*-releasefor production)yarn publish-betaoryarn publish-prod(note: with dash)The publish command will only bump versions in package.json files, tag the commit and push to remote. The CI will then test, build, and publish to NPM.
As discussed offline, this will remove the differences in local dev environments and ensure predictable results. Also saves us time from working around render test inconsistencies and random errors.
I have tested the version bumping and tagging part of the workflow. Can't verify the CI workflow until merged. May need to follow up with more PRs to fix any CI issues.
Change List
Change List (outside this PR)
*-releasebranches to admins only