Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore shaderlib test cases #8652

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Restore shaderlib test cases #8652

merged 1 commit into from
Mar 14, 2024

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Remove CPU smulation code path and dev dependency glsl-transpiler
  • Rewrite test cases for readability, add types
  • Restore project, project32, project64 shader module tests with v9 BufferTransform

@coveralls
Copy link

Coverage Status

coverage: 84.071%. remained the same
when pulling cea620c on x/shader-tests
into c83b87b on master.

donmccurdy
donmccurdy approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% of the coverage, 50% of the code! 👏🏻

@Pessimistress Pessimistress merged commit b1e0ba7 into master Mar 14, 2024
3 checks passed
@Pessimistress Pessimistress deleted the x/shader-tests branch March 14, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @donmccurdy