Remove dev dependency on react-map-gl v5 #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/react-map-gl
branch
from
bca44bd to
a022ed4
Compare
chrisgervang
approved these changes
Mar 10, 2024
Not intentionally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously the scripting bundle imports the mapbox wrapper from react-map-gl v5. That version is no longer being maintained. This PR ports the wrapper class to TS and removes the dev dependency.
Saves ~30k off the core bundle.
Change List
MapWrapperclass for scripting bundlereact-map-glv5