Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset isDragging state if panning is disabled dynamically #7940

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Reset isDragging state if panning is disabled dynamically #7940

merged 1 commit into from
Jun 8, 2023

Conversation

Pessimistress
Copy link
Collaborator

For #7933

In this use case, when dragRotate and dragPan are both disabled programmatically, the panend event handler is deregistered, leaving the isDragging state to true.

This change does not introduce new performance overhead because Deck's onDrag* events are still listening to pan* events, and the recognizer is never turned off.

Change List

  • Correct isDragging controller state when dragRotate and dragPan are both off.

@coveralls
Copy link

Coverage Status

coverage: 89.833%. remained the same when pulling 1b1ed57 on x/drag-state into 8a37934 on master.

@Pessimistress Pessimistress merged commit 52ef85d into master Jun 8, 2023
@Pessimistress Pessimistress deleted the x/drag-state branch June 8, 2023 15:53
Pessimistress added a commit that referenced this pull request Jun 14, 2023
@Pessimistress
Reset isDragging state if panning is disabled dynamically (#7940)
eaddd4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@chrisgervang chrisgervang Awaiting requested review from chrisgervang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @felixpalmer