Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogleMapsOverlay: requestRedraw when removing interleaved overlay #7902

Merged
merged 3 commits into from
May 18, 2023
Merged

GoogleMapsOverlay: requestRedraw when removing interleaved overlay #7902

merged 3 commits into from
May 18, 2023

Conversation

felixpalmer
Copy link
Collaborator

For #7888

Change List

  • requestRedraw when removing interleaved overlay
  • test

@felixpalmer felixpalmer requested a review from Pessimistress May 17, 2023 13:54
@coveralls
Copy link

coveralls commented May 17, 2023 •
edited
Loading

Coverage Status

Coverage: 89.829% (+0.001%) from 89.828% when pulling f23956c on felix/google-vector-null-map into b106327 on master.

@Pessimistress
Copy link
Collaborator

Should this be reported as a bug to Google Maps? I would expect setMap(null) to trigger a redraw on the map side.

@felixpalmer felixpalmer merged commit 772a7de into master May 18, 2023
@felixpalmer felixpalmer deleted the felix/google-vector-null-map branch May 18, 2023 08:20
Pessimistress pushed a commit that referenced this pull request May 22, 2023
@felixpalmer @Pessimistress
GoogleMapsOverlay: requestRedraw when removing interleaved overlay (#…
9c85a9e 
…7902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @coveralls @Pessimistress