Fix depth picking from GeoJSON layer for binary features #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabeboning
changed the title
gabeboning
force-pushed
the
binary-features-depth-picking
branch
from
579ed5d to
7d36e64
Compare
gabeboning
commented
Apr 21, 2023
modules/core/src/lib/layer.ts
Outdated
| values[i + 2] === objectColor[2] | ||
| ) { | ||
| this._disablePickingIndex(index); | ||
| break; |
There was a problem hiding this comment.
This break will prevent disabling picking colors correctly for multi polygons or multi line strings -- every match needs to disabled, not just the first one.
There was a problem hiding this comment.
I see, sorry about that. Could you kill the line and make sure this PR fixes the original issue before we merge? I think the only thing missing is unit tests, but I can add that in a follow up PR.
There was a problem hiding this comment.
Removed + verified that it works as I'd expect now!
Pessimistress
approved these changes
Apr 21, 2023
Pessimistress
added a commit
that referenced
this pull request
Apr 26, 2023
Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth picking from binary features does not work when the features are not all the same type (i.e. not all polygons). This is because the global feature index -- the index in the GeoJSON equivalent -- does not necessarily match the index of the feature/datum in each of the point/polygon/line sublayers.
This PR adds a
_getSublayerPickingIndexmethod to allow composite layers to translate picked ids from a global id into the correct one (or multiple, to correctly handle MultiPolygon/MultiLineString cases where a single global id has multiple local ids) to be used for clearing the picking buffer.It doesn't feel like the cleanest approach, but I do like that it keeps the knowledge about indices in the layer that would know (the composite parent). Happy to attempt it some other way if anyone has a proposed better approach; though this does seem to work reliably.