Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in getURLFromTemplate #6898

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix crash in getURLFromTemplate #6898

merged 1 commit into from
May 11, 2022

Conversation

Pessimistress
Copy link
Collaborator

For #6816

stringHash can return negative numbers and crash the template selection.

Change List

  • Force stringHash to return non-negative numbers
  • Test case

@Pessimistress Pessimistress requested a review from felixpalmer May 11, 2022 17:07
@Pessimistress Pessimistress merged commit 2d5ddd2 into master May 11, 2022
@Pessimistress Pessimistress deleted the x/tile-index-fix branch May 11, 2022 18:54
amuramoto pushed a commit to amuramoto/deck.gl that referenced this pull request May 20, 2022
@Pessimistress @amuramoto
Fix crash in getURLFromTemplate (visgl#6898)
85d942f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @kylebarron