Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geo-layers): unskip fixed test #6882

Merged
merged 2 commits into from
May 5, 2022
Merged

fix(geo-layers): unskip fixed test #6882

merged 2 commits into from
May 5, 2022

Conversation

belom88
Copy link
Collaborator

@belom88 belom88 commented May 4, 2022

For #6871

@belom88 belom88 linked an issue May 4, 2022 that may be closed by this pull request
[Bug] Tile3DLayer tests intermittently failing due to race condition #6871
Closed
6 tasks
@coveralls
Copy link

coveralls commented May 4, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.7%) to 81.973% when pulling 5726253 on vb/fix-uncomment-fixed-test into e4dcadf on master.

kylebarron
kylebarron approved these changes May 4, 2022
View reviewed changes
Copy link
Collaborator

@kylebarron kylebarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment as well?

@belom88 belom88 merged commit f992f64 into master May 5, 2022
zbigg pushed a commit that referenced this pull request May 5, 2022
@belom88 @zbigg
fix(geo-layers): unskip fixed test (#6882)
e26829a
@Pessimistress Pessimistress deleted the vb/fix-uncomment-fixed-test branch May 11, 2022 17:03
amuramoto pushed a commit to amuramoto/deck.gl that referenced this pull request May 20, 2022
@belom88 @amuramoto
fix(geo-layers): unskip fixed test (visgl#6882)
ebf0293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylebarron kylebarron kylebarron approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Tile3DLayer tests intermittently failing due to race condition
3 participants
@belom88 @coveralls @kylebarron