Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] CartoLayer (carto) #6821

Merged
merged 1 commit into from
Apr 19, 2022
Merged

[ts] CartoLayer (carto) #6821

merged 1 commit into from
Apr 19, 2022

Conversation

zbigg
Copy link
Collaborator

@zbigg zbigg commented Apr 14, 2022

For #5589

Change List

  • Type CartoLayer

@coveralls
Copy link

coveralls commented Apr 14, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 81.94% when pulling b6d8e04 on zbigg/typescript-carto-layer-v2 into 1cf1eb0 on master.

@zbigg zbigg force-pushed the zbigg/typescript-carto-layer-v2 branch 2 times, most recently from 29a128f to baeabcf Compare April 14, 2022 11:28
@zbigg zbigg force-pushed the zbigg/typescript-carto-layer-v2 branch from baeabcf to b6d8e04 Compare April 14, 2022 13:07
@zbigg zbigg marked this pull request as ready for review April 14, 2022 13:24
@zbigg zbigg requested a review from felixpalmer April 14, 2022 13:24
felixpalmer
felixpalmer approved these changes Apr 15, 2022
View reviewed changes
modules/carto/src/layers/carto-layer.ts
export default class CartoLayer extends CompositeLayer {
initializeState() {
export interface CartoLayerProps<DataT = any> extends CompositeLayerProps<DataT> {
/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding these!

@zbigg zbigg merged commit 52bf845 into master Apr 19, 2022
@Pessimistress Pessimistress deleted the zbigg/typescript-carto-layer-v2 branch April 20, 2022 17:39
amuramoto pushed a commit to amuramoto/deck.gl that referenced this pull request May 20, 2022
@zbigg @amuramoto
CartoLayer converted to typescript (visgl#6821)
9d1766c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbigg @coveralls @felixpalmer