Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/picking to TypeScript #6776

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Migrate core/picking to TypeScript #6776

merged 1 commit into from
Apr 4, 2022

Conversation

Pessimistress
Copy link
Collaborator

For #5589

Change List

  • DeckPicker and utils

@Pessimistress Pessimistress requested a review from ibgreen March 25, 2022 05:25
@coveralls
Copy link

coveralls commented Mar 25, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 82.043% when pulling 2649982 on x/picking-ts into 9e68f73 on master.

@kylebarron
Copy link
Collaborator

kylebarron commented Mar 25, 2022 •
edited
Loading

Hmm, looks like test-python is failing due to a regression in a Python dependency. pypa/setuptools#3199

I can take a look at this

Edit: Also excited to see the types 😄

ibgreen
ibgreen approved these changes Mar 30, 2022
View reviewed changes
modules/core/src/lib/layer.js Show resolved Hide resolved
modules/core/src/lib/picking/pick-info.ts Show resolved Hide resolved
@Pessimistress Pessimistress merged commit 7f5012f into master Apr 4, 2022
@Pessimistress Pessimistress deleted the x/picking-ts branch April 4, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pessimistress @coveralls @kylebarron @ibgreen