Update dev setup to support modern JS syntax #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Feb 23, 2021
test/bench/node.js
Outdated
| @@ -1,3 +1,3 @@ | |||
| require('reify'); | |||
| require('@babel/register'); | |||
There was a problem hiding this comment.
Noooo not babel register..., please let me debug untranspiled code.... ;)
Just bump to node 14 to ecma script 2020 support.
There was a problem hiding this comment.
Node.js does not support our style of module imports (a mix of es modules and commonjs).
reify was meant to add that support, however it crashes on ECMA 2020 syntax. The module has also not been updated for 2 years.
I have added an explicit option to @babel/register to only use transforms that are needed by Node 14.
There was a problem hiding this comment.
Got it, that is not too bad. FWIW, there is esm too (reify alternative) it may be more up to date.
alasarr
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List
babel-plugin-inline-webgl-constantsremoves importtest benchfailure