Add on-screen warning when no Mapbox token exists. #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also turn on ScatterplotLayer by default; without anything visible on the map, the example feels unfinished IMO. (Especially when there's no basemap visible.) But open to disagreement on that.
|
|
ibgreen
approved these changes
Mar 30, 2017
| @@ -35,7 +35,9 @@ class App extends PureComponent { | |||
| pitch: 30, | |||
| bearing: 0 | |||
| }, | |||
| activeExamples: {}, | |||
| activeExamples: { | |||
| ScatterplotLayer: true | |||
There was a problem hiding this comment.
Maybe add a comment here stating the logic (same text you put in this PR)
| render() { | ||
| const {settings, activeExamples, hoveredItem, clickedItem} = this.state; | ||
|
|
||
| return ( | ||
| <div> | ||
| { this._renderMap() } | ||
| { !MAPBOX_ACCESS_TOKEN && this._renderNoTokenWarning() } |
There was a problem hiding this comment.
Could move this check inside the function.
| @@ -176,7 +178,7 @@ class App extends PureComponent { | |||
| const {width, height, mapViewState, settings: {effects}} = this.state; | |||
| return ( | |||
| <MapboxGLMap | |||
| mapboxApiAccessToken={MAPBOX_ACCESS_TOKEN} | |||
| mapboxApiAccessToken={MAPBOX_ACCESS_TOKEN || 'no_token'} | |||
There was a problem hiding this comment.
What does sending in 'no_token' achieve?
Closed
ericsoco
added a commit
that referenced
this pull request
Mar 30, 2017
Also turn on ScatterplotLayer by default; without anything visible on the map, the example feels unfinished IMO. (Especially when there's no basemap visible.) But open to disagreement on that.
gnavvy
pushed a commit
that referenced
this pull request
Mar 30, 2017
Also turn on ScatterplotLayer by default; without anything visible on the map, the example feels unfinished IMO. (Especially when there's no basemap visible.) But open to disagreement on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also turn on ScatterplotLayer by default; without anything visible on the map, the example feels unfinished IMO. (Especially when there's no basemap visible.) But open to disagreement on that.
Supercedes #509, which had an errant commit from another branch.