Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cloud layer example fix for the layer browser #490

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

howtimeflies0
Copy link

Comment out modelMatrix.rotateZ and modelMatrix.rotateX for the point cloud layer in the layer browser as we removed those controls in a previous commit

@howtimeflies0 howtimeflies0 changed the title Cloud layer example fix for the layer browser Point cloud layer example fix for the layer browser Mar 29, 2017
@howtimeflies0
Copy link
Author

@ibgreen

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: A small push for adding comments explaining why we keep the commented code. I assume there is something higher up in the file but may not be easy for someone reading the code for the first time to make the connection.

Shaojing Li added 2 commits March 29, 2017 13:28
… cloud layer in the layer browser as we removed those controls in a previous commit
@howtimeflies0 howtimeflies0 force-pushed the point-cloud-example-fix branch from 0eff017 to 0208051 Compare March 29, 2017 20:29
@howtimeflies0 howtimeflies0 merged commit e8eafaf into master Mar 29, 2017
@howtimeflies0 howtimeflies0 deleted the point-cloud-example-fix branch March 29, 2017 21:35
gnavvy pushed a commit that referenced this pull request Mar 30, 2017
* Comment out modelMatrix.rotateZ and modelMatrix.rotateX for the point cloud layer in the layer browser as we removed those controls in a previous commit

* address review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants