Remove BitmapLayer and MeshLayer from layer browser. #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, RotationZ and effect controls from the layer browser.
howtimeflies0
force-pushed
the
layer-browser-fix
branch
from
eff9e04 to
e455408
Compare
ibgreen
approved these changes
Mar 28, 2017
There was a problem hiding this comment.
I normally am not in favor of leaving in commented code but this could be a reasonable exception.
Especially the rotation controls as they are needed to test the modelMatrix and lighting support.
I do believe that the convention when leaving commented code should be to add a line explaining why it was commented out and not cut.
howtimeflies0
force-pushed
the
layer-browser-fix
branch
from
49cfb89 to
2e27664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove RotationX, RotationZ and effect controls from the layer browser. The only layer in the layer browser that responds to RotationX and RotationZ is the point cloud layer due to projection mode settings. It makes those controls seem like broken while they are not. So I decide to remove them to clear the confusions.
I commented out most of the lines instead of removing them.