Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace lat lon offset with cellSize #460

Merged
merged 2 commits into from
Mar 24, 2017
Merged

replace lat lon offset with cellSize #460

merged 2 commits into from
Mar 24, 2017

Conversation

heshan0131
Copy link
Collaborator

No description provided.

howtimeflies0
howtimeflies0 reviewed Mar 24, 2017
View reviewed changes
examples/layer-browser/src/utils/grid-aggregator.js
* @returns {object} - grid data and cell dimension
*/
export function pointsToWorldGrid(points, worldUnitSize) {
export function pointsToWorldGrid(points, cellSize) {
Copy link

@howtimeflies0 howtimeflies0 Mar 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you changed all worldUnitSize to cellSize here. Should we do the same in src/layers/core/grid-layer/grid-aggregator.js ?

howtimeflies0
howtimeflies0 approved these changes Mar 24, 2017
View reviewed changes
Copy link

@howtimeflies0 howtimeflies0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cellSize slider of the grid-cell-layer example in the layer-browser seems to be mapped to a wrong range. We need to fix that

ibgreen
ibgreen approved these changes Mar 24, 2017
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this aligns the APIs nicely.

@heshan0131 heshan0131 merged commit dd56cd4 into master Mar 24, 2017
@ibgreen ibgreen deleted the grid-cellSize branch March 28, 2017 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howtimeflies0 howtimeflies0 howtimeflies0 approved these changes

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heshan0131 @ibgreen @howtimeflies0