Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PointCloudLayer bug where radiusPixels is not working #449

Merged
merged 3 commits into from
Mar 22, 2017
Merged

Fix PointCloudLayer bug where radiusPixels is not working #449

merged 3 commits into from
Mar 22, 2017

Conversation

Pessimistress
Copy link
Collaborator

  • Use radiusPixels instead of radius in rendering
  • Better data sample in layer browser

howtimeflies0
howtimeflies0 reviewed Mar 22, 2017
View reviewed changes
src/layers/core/point-cloud-layer/point-cloud-layer.js Outdated
this.state.model.render(Object.assign({}, uniforms, {
radius
radius: radiusPixels
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just update the uniform names in the shader to "radiusPixels"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just update the uniform names in the shader to "radiusPixels"

Agreed. Let's keep uniforms and prop names aligned when we can.

ibgreen
ibgreen approved these changes Mar 22, 2017
View reviewed changes
src/layers/core/point-cloud-layer/point-cloud-layer.js Outdated
this.state.model.render(Object.assign({}, uniforms, {
radius
radius: radiusPixels
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just update the uniform names in the shader to "radiusPixels"

Agreed. Let's keep uniforms and prop names aligned when we can.

@Pessimistress Pessimistress merged commit e2c4d0a into master Mar 22, 2017
@Pessimistress Pessimistress deleted the pointcloud branch March 22, 2017 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howtimeflies0 howtimeflies0 howtimeflies0 approved these changes

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @ibgreen @howtimeflies0