Fix the position generation for extruded polygons with holes #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Mar 22, 2017
| @@ -87,6 +87,7 @@ export class PolygonTesselatorExtruded { | |||
| } | |||
|
|
|||
| function countVertices(vertices) { | |||
|
|
|||
| const topVertices = [].concat(vertices); | ||
| const positions = groupedVertices.map( | ||
| vertices => { | ||
| const topVertices = Array.prototype.concat.apply([], vertices); |
There was a problem hiding this comment.
What's the difference here?
There was a problem hiding this comment.
Yeah, the bug is that applying double map() to groupedVertices changes the sequence of the vertices. So I reverted back to a single map() as in ExtrudedChoroplethLayer.
However, to use single map(), I need to use concat.apply() to have topVertices in the flattened format for the baseVertices to be correctly calculated on the next line.
It took me some time to figure out that
[].concat([[1, 2, 3]]) is [[1, 2, 3]],
Array.prototype.concat.apply([], [[1, 2, 3]]) is [1, 2, 3]
Learned a Javascript lesson....
Fix the polygon layer example in the layer browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ibgreen @Pessimistress @gnavvy