Composite layer interface and props transfer #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…confusion; Change the way composite layers pass their props to their underlying layers. Now it requires explicitly passing in renderLayers()
ibgreen
approved these changes
Mar 18, 2017
| const drawPoints = pointFeatures && pointFeatures.length > 0; | ||
| const drawLines = lineFeatures && lineFeatures.length > 0; | ||
| const hasPolygonOutline = polygonOutlineFeatures && polygonOutlineFeatures.length > 0; | ||
| const hasPolygonLine = polygonOutlineFeatures && polygonOutlineFeatures.length > 0; |
|
|
||
| const polygonWireframeLayer = wireframe && | ||
| extruded && | ||
| hasPolygon && | ||
| new SolidPolygonLayer(Object.assign({}, this.props, { |
There was a problem hiding this comment.
Looks good to get rid of the Object.assign here.
| polygonOutlineLayer, | ||
| lineLayer, | ||
| polygonLineLayer, | ||
| pathLayer, | ||
| pointLayer | ||
| ].filter(Boolean); |
There was a problem hiding this comment.
We should to add the filtering by default inside deck.gl - Because I see so many layers doing .filter(Boolean) thing now. React supports null/empty elements, we should too. I think it is a one line change, could even go into this PR.
There was a problem hiding this comment.
Agree. but let's do it in a different PR
| @@ -35,6 +35,7 @@ const defaultProps = { | |||
| elevationRange: defaultElevationRange, | |||
| elevationScale: defaultElevationScale, | |||
| getPosition: x => x.position, | |||
| extruded: false, | |||
| fp64: false | |||
| // AUDIT - getWeight ? | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the interface of GeoJson layer and Polygon layer to clear the confusion
Change the way composite layers pass their props to their underlying layers. Now it requires explicitly passing. Layers affected are the GeoJsonLayer, PolygonLayer, GridLayer, and HexagonLayer.
Docs change will be in an updated #436
@Pessimistress @ibgreen @gnavvy