Fix the bug that Layer's invalidateAttribute get called for CompositeLayer #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich has no AttributeManager so no attribute to invalidate); Clean up the accessor and prop names for Polygon layer and GeoJson layer;
ibgreen
approved these changes
Mar 14, 2017
src/lib/composite-layer.js
Outdated
| @@ -7,7 +7,15 @@ export default class CompositeLayer extends Layer { | |||
|
|
|||
| // initializeState is usually not needed for composite layers | |||
| // Provide empty definition to disable check for missing definition | |||
| initializeState() {} | |||
| initializeState() { | |||
|
|
|||
There was a problem hiding this comment.
Nit: I could go either way on the braces but I don't think we need an empty line
src/lib/composite-layer.js
Outdated
| // No-op for the invalidateAttribute function as the composite | ||
| // layer has no AttributeManager | ||
| invalidateAttribute() { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
, which has no AttributeManager so no attribute to invalidate;
Clean up the accessor and prop names for Polygon layer and GeoJson layer