Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(readme): fixes bad link in the README.md #3340

Merged
merged 1 commit into from
Jul 11, 2019
Merged

chore(readme): fixes bad link in the README.md #3340

merged 1 commit into from
Jul 11, 2019

Conversation

pranshuchittora
Copy link
Contributor

For doc

Background

Hit 404, while reading the docs

Change List

  • Fixes 404 link for webpack in the README.md

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.6%) to 82.211% when pulling 7382217 on pranshuchittora:docs-readme into b579f8f on uber:master.

Pessimistress
Pessimistress approved these changes Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pessimistress Pessimistress merged commit 945e2c8 into visgl:master Jul 11, 2019
@pranshuchittora
Copy link
Contributor Author

Thank you @Pessimistress for blazing-fast approval.
I am looking forward to contribute more, unfortunately, I am not able to find any good first issue. Can you pls label a few or suggest something easy.

Looking forward to it.

@pranshuchittora pranshuchittora deleted the docs-readme branch July 11, 2019 21:37
ajduberstein pushed a commit that referenced this pull request Aug 1, 2019
@pranshuchittora
chore(readme): fixes bad link in the README.md (#3340)
4d45382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranshuchittora @CLAassistant @coveralls @Pessimistress