Add support for RGB color format #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xintongxia
approved these changes
Jul 11, 2019
|
|
||
| Setting it to `'RGB'` will make the layer ignore the alpha channel and assume `a: 255`. | ||
|
|
||
| Default `'RGBA'`. |
There was a problem hiding this comment.
3D tiles also have rgb565 color format. Do you think it could also be provided in deck.gl?
There was a problem hiding this comment.
No, that cannot be done without changing attribute generation.
tsherif
approved these changes
Jul 11, 2019
|
|
||
| Default `'XYZ'`. | ||
|
|
||
| ##### `colorFormat` (String, optional) |
There was a problem hiding this comment.
It might simplify things to make these numbers, e.g. positionDimensions and colorChannels. Then setting the size would just be size: this.props.colorChannels (with a default of 4). Also leaves the door open for passing fewer components (if that might ever be useful?).
There was a problem hiding this comment.
Unfortunately positionFormat has been a public API since v6. I can change the usage to size: this.props.colorFormat.length though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3197
There is a small save on resources, but this is most useful when using external buffers.
Change List
colorFormatproppositionFormatsupport inPolygonLayer