Add Brushing extension #3309
Merged
Add Brushing extension #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 2, 2019 15:14
tsherif
approved these changes
Jul 3, 2019
|
|
||
| // Trigger redraw when mouse moves | ||
| // TODO - expose this in a better way | ||
| extension.onMouseMove = () => { |
There was a problem hiding this comment.
Would it be worth it to just make capturing UI events part of the extension API? E.g.
this.onEvents({
pointermove: ...,
pointerleave: ...
});There was a problem hiding this comment.
The LayerExtension interface is supposed to mirror that of Layer. Layers can implement methods such as onHover onDrag but they are only called when the event is interacting with an object rendered by this layer. If we add a new API for generic event handling, it has to be supported in both layers and extensions.
ajduberstein
pushed a commit
that referenced
this pull request
Jul 13, 2019
ajduberstein
pushed a commit
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC
Change List
BrushingExtension