composite layer: pass extension props through #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Jul 2, 2019
| newProps[key] = propValue; | ||
| if (propDef && propDef.type === 'accessor') { | ||
| newProps.updateTriggers[key] = this.props.updateTriggers[key]; | ||
| // Unwrap sublayer objects before passing to accessor |
There was a problem hiding this comment.
Just my 2 cents:
This adds a "hidden" unwrapObject method to some layers which feels a little iffy (Layer is already complex and contains a ton of methods some of which are ripe for cleanup).
The comment here didn't help me understand what "unwrap" means or why it is needed. Also could be valuable to point out if this just a hack for extensions or something more generically valuable for CompositeLayers? Should this be documented at some point? At least add some form of TODO?
| @@ -100,6 +100,10 @@ export default class PolygonLayer extends CompositeLayer { | |||
| }); | |||
| } | |||
|
|
|||
| unwrapObject(object) { | |||
There was a problem hiding this comment.
For some reason this one in particular looks rather hacky...
There was a problem hiding this comment.
Yes it is. I'll clean up in a follow up PR.
ajduberstein
pushed a commit
that referenced
this pull request
Jul 13, 2019
ajduberstein
pushed a commit
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3305
Change List