Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build script fixes, example cleanup #330

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Build script fixes, example cleanup #330

merged 1 commit into from
Jan 27, 2017

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Jan 27, 2017

No description provided.

gnavvy
gnavvy approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@gnavvy gnavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this diff, but would be great to change the range of the strokeWidth slide for the geoJson layer to exclude 0.
gl.INVALID_VALUE was caused by call to: gl.lineWidth(0)

@ibgreen ibgreen merged commit eabf8ef into dev Jan 27, 2017
@ibgreen ibgreen deleted the various-fixes branch January 27, 2017 21:02
@ibgreen
Copy link
Collaborator Author

ibgreen commented Jan 27, 2017

@gnavvy

@Pessimistress wants to remove strokeWidth completely for GL.LINE based rendering since Chrome is withdrawing support. I'm fine with that. GL.LINE will basically be useful for wireframes only.

@gnavvy
Copy link
Contributor

gnavvy commented Jan 27, 2017 •
edited
Loading

for GL.LINE based rendering, sure I'm 100% for it.

howtimeflies0 pushed a commit that referenced this pull request Mar 8, 2017
@ibgreen
Example and build cleanup (#330)
02e9a18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnavvy gnavvy gnavvy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibgreen @gnavvy