Composite GeoJsonLayer, PolygonLayer and PathLayer #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y on PolygonLayer
gnavvy
reviewed
Jan 24, 2017
|
|
||
| #### `drawContour` (Boolean, optional) | ||
|
|
||
| Draw choropleth contour if true, else fill choropleth area. |
There was a problem hiding this comment.
need to update the document after the API audit, we don't have drawContour as prop for the GeoJsonLayer, and there are more layer specific props.
| import PolygonLayer from '../polygon-layer/polygon-layer'; | ||
| import flatten from 'lodash.flatten'; | ||
|
|
||
| import {Container, getGeojsonFeatures} from '../../../lib/utils'; |
There was a problem hiding this comment.
shall we keep the layer specific util function in their own folders?
getGeojsonFeatures -> geoJson layer
normalizeGeojson -> deprecated choropleth layer
| ); | ||
| } | ||
|
|
||
| getFeaturePolygons(feature) { |
| import {join} from 'path'; | ||
|
|
||
| // Polygon geometry generation is managed by the polygon tesselator | ||
| import {Container, getGeojsonFeatures, featureToPolygons} from '../../../lib/utils'; |
There was a problem hiding this comment.
the polygon layer should not be aware of the concept feature, the featureToPolygons should be done in the geoJson-layer.
Closed
heshan0131
pushed a commit
to heshan0131/deck.gl
that referenced
this pull request
Jan 24, 2017
* Composite geojson layer, with flat, extrusion and wireframe capability on PolygonLayer * Lighting supported on polygon layer. New lighting shader module. * Lighting supported on polygon layer. New lighting shader module. * v3.1.0-beta.11 * v3.0.0-beta.12
howtimeflies0
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Composite geojson layer, with flat, extrusion and wireframe capability on PolygonLayer * Lighting supported on polygon layer. New lighting shader module. * Lighting supported on polygon layer. New lighting shader module. * v3.1.0-beta.11 * v3.0.0-beta.12
howtimeflies0
pushed a commit
that referenced
this pull request
Mar 8, 2017
* Composite geojson layer, with flat, extrusion and wireframe capability on PolygonLayer * Lighting supported on polygon layer. New lighting shader module. * Lighting supported on polygon layer. New lighting shader module. * v3.1.0-beta.11 * v3.0.0-beta.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PolygonLayer supports flat, extrusion and wireframe