Improve picking color generation #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsherif
reviewed
Feb 19, 2019
There was a problem hiding this comment.
Main concern here is the internal cache pointing the the value arrays in the attributes it gets as arguments. Seems like a data-corruption risk, since it's unclear who owns the array. Since the values are always the same, would it make sense to generate the pick values array externally, and send it to the pick color attributes? I.e. make that an explicit part of the attributes API.
tsherif
approved these changes
Feb 19, 2019
Pessimistress
added a commit
that referenced
this pull request
Feb 20, 2019
Pessimistress
added a commit
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate picking color for 1M instances, before: 45 iterations/s; after: 412 iterations/s
Since
layer.calculateInstancePickingColorsalways produces the same sequence, we can save the largest generated array and copy its value into others.We can potentially make all
instancePickingColorsattributes share the same WebGLBuffer, but that would introduce more complexity around:Change List
layer.calculateInstancePickingColors