specify types for defaultProps in PathMarkerLayer #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,18 +22,21 @@ const defaultProps = Object.assign({}, PathOutlineLayer.defaultProps, { | |||
| MarkerLayer: DEFAULT_MARKER_LAYER, | |||
| markerLayerProps: DEFAULT_MARKER_LAYER_PROPS, | |||
|
|
|||
| sizeScale: 100, | |||
| sizeScale: {type: 'number', value: 100, min: 1}, | |||
| getMarkerPercentages: (object, {lineLength}) => | ||
| lineLength > DISTANCE_FOR_MULTI_ARROWS ? [0.25, 0.5, 0.75] : [0.5] | ||
| getPath: {type: 'accessor', value: x => x.path}, | ||
| getColor: {type: 'accessor', value: x => x.color}, |
There was a problem hiding this comment.
Is this prop used anywhere?
There was a problem hiding this comment.
yes, it is used in createPathMarkers.
https://github.com/uber/deck.gl/blob/master/modules/experimental-layers/src/path-marker-layer/create-path-markers.js#L28
in lines 28, 46 and 58.
There was a problem hiding this comment.
it is not used. I removed it
| getPath: {type: 'accessor', value: x => x.path}, | ||
| getColor: {type: 'accessor', value: x => x.color}, | ||
| getMarkerColor: {type: 'accessor', value: [0, 0, 0, 255]}, | ||
| getDirection: {type: 'accessor', value: x => x.direction}, |
There was a problem hiding this comment.
Does this have to be a function?
There was a problem hiding this comment.
it's changed to a const
XiaokaiUber
force-pushed
the
specify-types-for-defaultProps-path-marker-layer
branch
from
0510130 to
4251e35
Compare
jianhuang01
approved these changes
Feb 9, 2019
| getMarkerPercentages = x => [0.5], | ||
| getDirection = DEFAULT_DIRECTION, | ||
| getColor = DEFAULT_COLOR, | ||
| getMarkerPercentages = [0.5], |
There was a problem hiding this comment.
You're using this as a function but the default value is a constant
Pessimistress
approved these changes
Feb 11, 2019
XiaokaiUber
deleted the
specify-types-for-defaultProps-path-marker-layer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2477
Background
In PathMarkerLayer, the defaultProps don't have types specified. We need to specify types for those props.
Change List
note: tested in layer browser