Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify default props for trips layer #2644

Merged
merged 1 commit into from
Jan 30, 2019
Merged

specify default props for trips layer #2644

merged 1 commit into from
Jan 30, 2019

Conversation

XiaokaiUber
Copy link
Contributor

For #2477

Background

In trips layer, the defaultProps don't have types specified. We need to specify type for those props.

Change List

  • Add type to the defaultProps in path outline layer

note: compared the rendering result of trips example with that in 6.3-release

@XiaokaiUber XiaokaiUber merged commit 8156a2b into master Jan 30, 2019
@XiaokaiUber XiaokaiUber deleted the update-props-trips-layer branch January 30, 2019 23:30
xintongxia pushed a commit that referenced this pull request Feb 6, 2019
@XiaokaiUber
specify default props for trips layer (#2644)
cf2c4f1
Pessimistress pushed a commit that referenced this pull request Feb 8, 2019
@XiaokaiUber
specify default props for trips layer (#2644)
389590a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhuang01 jianhuang01 jianhuang01 approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XiaokaiUber @jianhuang01