Remove prefixes for grab and grabbing cursor values. #2629
Conversation
Those prefixes are not needed in the latest version of Chrome and Safari, so we can safely remove them. Fixes visgl#2618.
|
|
|
Everything looks cool. Could someone review these changes? |
There was a problem hiding this comment.
PR looks great.
Note to self: We really should get rid of the double definition of cursors, a bit embarrassing that you had to chase that down.
We may not even need the lookup at this point (unless we want to start using e.g. custom dataUrl cursors), so maybe just use the CSS names directly in the code, then we don't have to figure out how to make these definitions available in two modules without adding extra exports.
| @@ -31,17 +31,14 @@ import {Stats} from 'probe.gl'; | |||
| import {EventManager} from 'mjolnir.js'; | |||
|
|
|||
| import assert from '../utils/assert'; | |||
| import VENDOR_PREFIX from '../utils/css-vendor-prefix'; | |||
There was a problem hiding this comment.
I believe this file can be safely removed.
| @@ -18,15 +18,8 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| // import browser from 'bowser'; | |||
|
|
|||
| const PREFIX = '-webkit-'; | |||
There was a problem hiding this comment.
I don't see this file being imported anywhere. Just remove?
It's not used anywhere anymore, so it's safe to remove it. We also remove its test file.
|
Thanks for the reviews. I deleted all unused file, inlined |
Those prefixes are not needed in the latest version of Chrome
and Safari, so we can safely remove them.
Fixes #2618.